Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump language-formatters-pre-commit-hooks to 1.4.2 #133

Merged
merged 3 commits into from
Jun 9, 2020

Conversation

cortinico
Copy link
Collaborator

@cortinico cortinico commented Jun 4, 2020

This comes with a bump of KtLint to 0.37.1

@cortinico cortinico added the infra PR or Issue related to project infrastructure label Jun 4, 2020
@cortinico cortinico added this to the 2.0.0 milestone Jun 4, 2020
@cortinico cortinico requested a review from macisamuele June 4, 2020 19:20
Copy link
Collaborator

@macisamuele macisamuele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually compared the PR with master by ignoring whitespaces (to make the review easier) and it makes sense to me.

Please before merging this ensure that :samples:kotlin-coroutines:lint is green (currently is failing)

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #133 into master will decrease coverage by 0.18%.
The diff coverage is 89.58%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     74.56%   74.38%   -0.19%     
  Complexity      173      173              
============================================
  Files            11       11              
  Lines           684      687       +3     
  Branches         86       86              
============================================
+ Hits            510      511       +1     
- Misses          128      130       +2     
  Partials         46       46              
Impacted Files Coverage Δ Complexity Δ
.../main/java/com/yelp/codegen/plugin/GenerateTask.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...m/yelp/codegen/plugin/GenerateTaskConfiguration.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/src/main/java/com/yelp/codegen/SharedCodegen.kt 61.98% <55.55%> (+0.22%) 63.00 <0.00> (ø)
.../src/main/java/com/yelp/codegen/KotlinGenerator.kt 87.61% <100.00%> (ø) 88.00 <13.00> (ø)
...ugin/plugin/src/main/java/com/yelp/codegen/Main.kt 98.38% <100.00%> (ø) 4.00 <0.00> (ø)
...rc/main/java/com/yelp/codegen/utils/StringUtils.kt 100.00% <100.00%> (ø) 6.00 <2.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ebe35...1286f48. Read the comment docs.

@cortinico
Copy link
Collaborator Author

Currently blocked due to pinterest/ktlint#761

@cortinico cortinico changed the title Bump language-formatters-pre-commit-hooks to 1.4.1 Bump language-formatters-pre-commit-hooks to 1.4.2 Jun 8, 2020
@cortinico cortinico merged commit b392529 into master Jun 9, 2020
@cortinico cortinico deleted the language-formatters-pre-commit-hooks-to-1.4.1 branch June 9, 2020 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra PR or Issue related to project infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants