Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump io.swagger:swagger-codegen from 2.3.1 to 2.4.12 #91

Merged
merged 5 commits into from
Feb 4, 2020
Merged

Bump io.swagger:swagger-codegen from 2.3.1 to 2.4.12 #91

merged 5 commits into from
Feb 4, 2020

Conversation

macisamuele
Copy link
Collaborator

This PR does nothing more than bumping the swagger-codegen dependency.

There are no specific changes in the new version that makes the tool better as well as the generated code (in our samples) has no changes if we're using the old or new version.

The bump is still recommended as generateSwagger gradle task might be used to gate in templates available on swagger-codegen and bumping the library would allow this use-case to get updated templates.

An example of generating python code might look like

generateSwagger {
    platform = "python"
    specName = "kotlincoroutines"
    inputFile = file("../sample_specs.json")
    outputDir = file(".")
}

@macisamuele macisamuele added the infra PR or Issue related to project infrastructure label Feb 4, 2020
@macisamuele macisamuele requested a review from cortinico February 4, 2020 11:30
@macisamuele macisamuele self-assigned this Feb 4, 2020
@macisamuele macisamuele force-pushed the maci-bump-swagger-codegen-2 branch from 1855348 to 26cfafe Compare February 4, 2020 19:44
cortinico
cortinico reviewed Feb 4, 2020
View reviewed changes
plugin/src/main/java/com/yelp/codegen/SharedCodegen.kt
@@ -1,13 +1,13 @@
package com.yelp.codegen

import com.yelp.codegen.utils.InlineModelResolver
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:O

cortinico
cortinico approved these changes Feb 4, 2020
View reviewed changes
Copy link
Collaborator

@cortinico cortinico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢
Also we're finally a 100% Kotlin Project!

@cortinico cortinico added enhancement New feature or request and removed infra PR or Issue related to project infrastructure labels Feb 4, 2020
@cortinico cortinico added this to the 1.4.0 milestone Feb 4, 2020
@macisamuele macisamuele merged commit 5ab43f0 into Yelp:master Feb 4, 2020
@macisamuele macisamuele deleted the maci-bump-swagger-codegen-2 branch February 4, 2020 21:27
@macisamuele macisamuele mentioned this pull request Feb 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cortinico cortinico cortinico approved these changes

Assignees

@macisamuele macisamuele

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@macisamuele @cortinico