Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test expectation #166

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix test expectation #166

wants to merge 2 commits into from

Conversation

ymilki
Copy link
Member

@ymilki ymilki commented Nov 17, 2023 •
edited
Loading

Problem

This test was updated in #165 but the assertion truncated the full path to the resource.
Furthermore, importlib.resources.files and importlib.resources.as_file were introduced in py39 and require a backport for older python.

Solution

  • Update test with the additional resource name
  • Use importlib_resources when required

@ymilki
T Fix test expectation
2c84fca 
* Test is expecting the full path to the resource
@ymilki
D Add importlib-resources import for older python
07b76f2 
* `importlib.resources.files` and `importlib.resources.as_file` were
  added in py39
@ymilki ymilki marked this pull request as ready for review November 18, 2023 00:02
@ymilki ymilki requested review from kaisen and benbariteau November 18, 2023 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisen kaisen Awaiting requested review from kaisen

@benbariteau benbariteau Awaiting requested review from benbariteau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ymilki