-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tensorpack Update and OpenCv dependency #16
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is the error received if Tensorpack update not included.
|
Closed
The OpenCv output can be viewed here #15 (comment) |
ppwwyyxx
reviewed
Mar 17, 2018
cifar10-densenet.py
Outdated
if args.gpu: | ||
config.nr_tower = len(args.gpu.split(',')) | ||
SyncMultiGPUTrainer(config).train() | ||
else: | ||
config.nr_tower = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting config.nr_tower
has no effect any more.
Using SyncMultiGPUTrainer(num_gpu)
is sufficient.
ppwwyyxx
added a commit
to tensorpack/tensorpack
that referenced
this pull request
Mar 17, 2018
@ppwwyyxx please check now |
Looks good! |
Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The repository in the current form was not functional due to an update with Tensorpack. This pull request is inspired by the issue tensorpack/tensorpack#458. Moreover, it was found that OpenCv-Python is actually required for execution, hence, it was added as dependency in the ReadMe file.
I have made the necessary changes and tried them on my server with Ubuntu 17.04, Nvidia GTX-1050 and Cuda 8.0. It appears to be working fine now.
Please update.
Thank you.