Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA: declare static closures as static #121

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Mar 22, 2021

Context

  • Code quality

Summary

This PR can be summarized in the following changelog entry:

  • Code quality

Relevant technical choices:

  • No functional changes.
  • Code style compliance.

Closures not using $this should be declared as static.

Includes minor whitespace fixes for the space between the function keyword and the opening parenthesis.

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • N/A
    This is a code-only change and should have no effect on the functionality. If the build passes (linting, test runs), we're good.

Closures not using `$this` should be declared as `static`.

Includes minor whitespace fixes for the space between the `function` keyword and the opening parenthesis.
@jrfnl jrfnl added this to the 4.2 milestone Mar 22, 2021
@jrfnl jrfnl merged commit e0c48b8 into develop Mar 22, 2021
@jrfnl jrfnl deleted the JRF/QA/static-closures branch March 22, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant