Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS: don't use Yoda conditions #123

Merged
merged 1 commit into from
Mar 22, 2021
Merged

Conversation

jrfnl
Copy link
Contributor

@jrfnl jrfnl commented Mar 22, 2021

Context

  • Code style consistency

Summary

This PR can be summarized in the following changelog entry:

  • Code style consistency

Relevant technical choices:

  • No functional changes.
  • Code style compliance.

YoastCS prohibits the use of Yoda conditions as it decreases the readability of code.

There are other sniffs in place to prevent accidentally using an assignment in a condition (which is what Yoda conditions is supposed to prevent).

Test instructions

This PR can be tested by following these steps:

  • N/A
    This is a code-only change and should have no effect on the functionality. If the build passes (linting, test runs), we're good.

YoastCS prohibits the use of Yoda conditions as the decrease the readability of code.

There are other sniffs in place to prevent accidentally using an assignment in a condition.
@jrfnl jrfnl added this to the 4.2 milestone Mar 22, 2021
@jrfnl jrfnl merged commit b92aa35 into develop Mar 22, 2021
@jrfnl jrfnl deleted the JRF/CS/dont-use-yoda-conditions branch March 22, 2021 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant