Travis: only lint against high/low PHP and run tests on more PHP versions #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions
As it was, the unit tests were only being run against PHP 7.4, while the plugin is supposed to be compatible with PHP 5.6 - 8.0.
To safeguard that properly, the tests should be run against all the supported PHP versions.
At this time, however, it is not (yet) possible to run the tests against PHP 8 due to the PHPUnit version being used (PHPUnit 5-7) in combination with certain tests features.
This will be fixed in the near future in a separate PR.
So, for now, this commit makes the following changes to the CI setup:
* Run the tests against all currently supported PHP versions, with the exception of PHP 8.0 which will be enabled at a later point in time.
* Only lint the code against high/low PHP versions, including against "future" PHP versions, like PHP 8.1 (nightly).
As the tests are being run on all PHP versions, we don't really need to lint against all PHP versions anymore as most parse errors would be discovered by the tests anyhow. So linting against the highest and lowest supported PHP versions, including against PHP version for which the test runs are not yet enabled will be sufficient.
|
Everything's working fine, merging |
enricobattocchi
deleted the
feature/QA/travis-test-against-more-php-versions
branch
|
@enricobattocchi Oi! It's weekend. Those PRs could easily have waited till Monday ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
As it was, the unit tests were only being run against PHP 7.4, while the plugin is supposed to be compatible with PHP 5.6 - 8.0.
To safeguard that properly, the tests should be run against all the supported PHP versions.
At this time, however, it is not (yet) possible to run the tests against PHP 8 due to the PHPUnit version being used (PHPUnit 5-7) in combination with certain tests features.
This will be fixed in the near future in a separate PR.
So, for now, this commit makes the following changes to the CI setup:
As the tests are being run on all PHP versions, we don't really need to lint against all PHP versions anymore as most parse errors would be discovered by the tests anyhow. So linting against the highest and lowest supported PHP versions, including against PHP version for which the test runs are not yet enabled will be sufficient.
Test instructions
This PR can be tested by following these steps: