Check_Changes_Handler_Test: fix bug #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was exposed by PHP 8.1. The `Check_Changes_Handler::check_changes_action_handler()` expects a global `$wp_version` variable to be available, but this variable was not created for the test, leading to a "Deprecated: version_compare(): Passing null to parameter #1 ($version1) of type string is deprecated" deprecation notices in PHP 8.1. Fixed by improving the test.
|
Everything's clear and OK, merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
This bug was exposed by PHP 8.1.
The
Check_Changes_Handler::check_changes_action_handler()expects a global$wp_versionvariable to be available, but this variable was not created for the test, leading to a "Deprecated: version_compare(): Passing null to parameter #1 ($version1) of type string is deprecated" deprecation notices in PHP 8.1.Fixed by improving the test.
Note: the value now chosen, maintains the existing behaviour of this test as
nullwould have been regarded as "less than 5.7".See: https://3v4l.org/Upb1h
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps: