Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUPP-32 Set dp-rewrite-republish as 'public' => false #213

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented Nov 30, 2021

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where Rewrite & Republish copies could be displayed and queried in the front end.

Relevant technical choices:

  • Also fixing some CS warnings in related test.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • visit the frontend with Debug Bar and/or Query Monitor installed and configured
  • check that the main query does not have OR $prefix.post_status = 'dp-rewrite-republish' in the WHERE
  • check that the R&R feature still works:
    • create a R&R copy from a published post, change something and republish it (check the logs that everything goes right)
    • create a R&R copy from a published post, change something, schedule its republishing 2 minutes in the future, wait to see everything goes right.

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes DUPP-32

@karlijnbok
Copy link
Contributor

CR & Acceptance: 👍

@karlijnbok karlijnbok added this to the 4.3 milestone Nov 30, 2021
@karlijnbok karlijnbok merged commit d96ed28 into trunk Nov 30, 2021
@karlijnbok karlijnbok deleted the DUPP-32-set-post-type-to-not-public branch November 30, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post status "dp-rewrite-republish" slows down WordPress
2 participants