DUPP-176 Prevent rendering of the block editor script when not on an edit screen #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
A plugin or a theme may (wrongfully) set the global var
$post
in the Widgets screen. This, paired with the fact that the Widgets screen executes theenqueue_block_editor_assets
even if there is no post to be edited, trigger the execution of outduplicate-post-edit.js
script, which fails because there is nocore/editor
store orPluginPostStatusInfo
component available.With the FSE transition undergoing, this might happen even more frequently.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Reproduce the error
master
(or use any 4.* version)functions.php
:Appearance
>Widgets
Test the fix
Appearance
>Widgets
Appearance
>Widgets
Copy to a new draft
andRewrite & Republish
are visible in theStatus and visibility
section of the sidebar.Copy to a new draft
is visible in theStatus and visibility
section of the sidebar.Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Documentation
Quality assurance
Fixes DUPP-176