Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DUPP-217 Fix welcome notice #229

Merged
merged 3 commits into from
Jan 13, 2022
Merged

DUPP-217 Fix welcome notice #229

merged 3 commits into from
Jan 13, 2022

Conversation

enricobattocchi
Copy link
Member

@enricobattocchi enricobattocchi commented Jan 13, 2022

Context

  • We want to fix the link in the welcome notice, and change copy references to update notice → welcome notice

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an unreleased bug where the link to the privacy policy was broken.

Relevant technical choices:

  • We also fixed the labels in the settings to refer to the welcome notice and not to update notice anymore

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • install on a clean environment
  • see the welcome notice, click on the "Privacy policy" link
  • visit Settings > Duplicate Post
  • navigate to the third tab "Display"
  • check that the last checkbox has labels referring to Welcome notice and not to Update notice anymore:
    Screenshot 2022-01-13 at 12-40-43 Duplicate Post Options ‹ Basic — WordPress

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Documentation

  • I have written documentation for this change.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes DUPP-217

@karlijnbok
Copy link
Contributor

Looks good! 👍

@karlijnbok karlijnbok merged commit 0b66e7a into release/4.4 Jan 13, 2022
@karlijnbok karlijnbok deleted the fix-welcome-notice branch January 13, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants