10267 add cornerstone toggle to sidebar #10405
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
reviewed
Jul 19, 2018
js/src/edit.js
Outdated
| @@ -13,6 +13,8 @@ import ClassicEditorData from "./analysis/classicEditorData.js"; | |||
| import isGutenbergDataAvailable from "./helpers/isGutenbergDataAvailable"; | |||
| import SnippetEditor from "./containers/SnippetEditor"; | |||
| import { ThemeProvider } from "styled-components"; | |||
| import CornerstoneToggle from "yoast-components/composites/Plugin/CornerstoneContent/components/CornerstoneToggle"; | |||
| import Styled from "styled-components"; | |||
There was a problem hiding this comment.
Styled should be lowercase: it's not a component.
afercia
reviewed
Jul 19, 2018
js/src/edit.js
Outdated
| @@ -35,6 +37,10 @@ function registerStoreInGutenberg() { | |||
| } ); | |||
| } | |||
|
|
|||
| const YoastSidebarContainer = Styled.div` | |||
There was a problem hiding this comment.
Styled should be lowercase
afercia
reviewed
Jul 19, 2018
js/src/edit.js
Outdated
| <YoastSidebarContainer> | ||
| <p> Contents of the sidebar </p> | ||
| <CornerstoneToggle onChange={ () => {} } checked={ true } /> | ||
| </YoastSidebarContainer> |
There was a problem hiding this comment.
Minor, I know this is for testing purposes but the indentation should be fixed.
|
CR 🚧 |
omarreiss
suggested changes
Jul 23, 2018
js/src/edit.js
Outdated
| <p> Contents of the sidebar </p> | ||
| <YoastSidebarContainer> | ||
| <p> Contents of the sidebar </p> | ||
| <CornerstoneToggle onChange={ () => {} } checked={ true } /> |
There was a problem hiding this comment.
Please make sure to rebase against the latest trunk and put this inside the <Fill>.
js/src/edit.js
Outdated
| @@ -35,6 +37,10 @@ function registerStoreInGutenberg() { | |||
| } ); | |||
| } | |||
|
|
|||
| const YoastSidebarContainer = styled.div` | |||
There was a problem hiding this comment.
It seems to me this padding shouldn't be on the sidebar itself, but on the underlying components. For instance, a <Collapsible> should have the padding (which it already does).
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Quality assurance
Requires #668