Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump deps #158

Merged
merged 1 commit into from
Apr 3, 2019
Merged

chore: bump deps #158

merged 1 commit into from
Apr 3, 2019

Conversation

jigsawye
Copy link
Collaborator

@jigsawye jigsawye commented Apr 3, 2019 •
edited
Loading

BEAKING CAHGNE: [Button] renamed prop name type to variant

@jigsawye jigsawye requested a review from kpman April 3, 2019 03:18
tw0517tw
tw0517tw reviewed Apr 3, 2019
View reviewed changes
packages/tailor-ui/src/Button/Button.tsx

export type ButtonProps = ButtonHTMLAttributes<HTMLButtonElement> &
SpaceProps &
WidthProps & {
loading?: boolean;
size?: ButtonSize;
type?: ButtonType;
variant?: ButtonVariant;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

這是 breaking change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

對

@jigsawye jigsawye merged commit 8a32481 into master Apr 3, 2019
@jigsawye jigsawye deleted the chore/bump-deps branch April 3, 2019 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tw0517tw tw0517tw tw0517tw approved these changes

@kpman kpman Awaiting requested review from kpman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jigsawye @tw0517tw