Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(menu): use default export #39

Merged
merged 1 commit into from
Jan 29, 2019
Merged

fix(menu): use default export #39

merged 1 commit into from
Jan 29, 2019

Conversation

jigsawye
Copy link
Collaborator

@jigsawye jigsawye commented Jan 8, 2019

原本的 GG 不能用
順便修 type

Copy link
Collaborator

@chentsulin chentsulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/lab 是幹嘛用的

@kpman
Copy link
Contributor

kpman commented Jan 8, 2019

改名叫 NewMenu 偏怪
之後可能會有 NewNewMenu 這類的命名嗎?

@chentsulin
Copy link
Collaborator

ModernMenu 或把以前的叫做 ClassicMenu 呢

@jigsawye
Copy link
Collaborator Author

jigsawye commented Jan 8, 2019

@chentsulin 原本是想用 'tailor-ui/lab' 去 import,不過 module 好像只支援一個 entry 所以就把它移出來了

@kpman 不會,因為這是我跟他的小秘密之後就會把原本的 Menu 拿掉

@jigsawye
Copy link
Collaborator Author

jigsawye commented Jan 8, 2019

/Users/jigsawye/projects/tailor-ui/node_modules/react-spring/hooks.js:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){import _inheritsLoose from '@babel/runtime/helpers/esm/inheritsLoose';
                                                                                                    ^^^^^^^^^^^^^^

    SyntaxError: Unexpected identifier

修不好,我不行惹 QQ

@jigsawye
Copy link
Collaborator Author

等了 17 天依然解決不了,再放一天就可以

image

@jigsawye jigsawye force-pushed the fix/new-menu-export branch from 953de23 to f86e4da Compare January 29, 2019 04:46
@jigsawye jigsawye force-pushed the fix/new-menu-export branch from f86e4da to a310499 Compare January 29, 2019 04:47
@jigsawye
Copy link
Collaborator Author

可以ㄌ

@chentsulin
Copy link
Collaborator

為啥 18 天就好了

@jigsawye
Copy link
Collaborator Author

@chentsulin 因為釀好了

@jigsawye jigsawye merged commit 3d08ebe into master Jan 29, 2019
@jigsawye jigsawye deleted the fix/new-menu-export branch January 29, 2019 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants