chore: bump deps #41
chore: bump deps #41
Conversation
|
測試跑不動 |
jigsawye
force-pushed
the
chore/bump-deps
branch
from
4e9a582 to
b9cbed3
Compare
| @@ -116,7 +116,8 @@ describe('Dropdown', () => { | |||
| expect(onDisabledItemClick).not.toBeCalled(); | |||
| }); | |||
|
|
|||
| it('should render subList when hover on Item and match snapshots', async () => { | |||
| // FIXME: test | |||
There was a problem hiding this comment.
初步研判 await wait(callback) 這個有點問題
改成下面這樣也跑不過
await wait(() => expect(1).toBe(1));而且詭異的是，一般來說應該會 timeout 的，不知道為啥不會 timeout 了，就持續的執行不完
There was a problem hiding this comment.
目前是感覺在那個 test it 裡面 setTimeout 不會正常運作，包括 wait 這個也會壞掉：
https://github.com/TheBrainFamily/wait-for-expect/blob/0f11a85f704561b98d87b8039855c925b422766d/src/index.ts#L48
There was a problem hiding this comment.
我那天修了一個多小時修不好直接放棄，skip 掉 XDD
There was a problem hiding this comment.
setup 完 setTimeout 就壞了，放前面過，放後面就卡
await new Promise(resolve => setTimeout(resolve, 0));
const { overlay, getByText } = await setup({
overlay: (
<Dropdown.List textAlign="center">
<Dropdown.Item key="Item 1">Item 1</Dropdown.Item>
<Dropdown.Item key="Item 2">Item 2</Dropdown.Item>
<Dropdown.SubList key="Item 3" title="Sub List">
<Dropdown.Item key="1">Sub Item</Dropdown.Item>
<Dropdown.SubList
key="Overflow Sub List"
title="Overflow Sub List"
maxHeight="200px"
overflow="auto"
>
<Dropdown.Item key="1">Sub List Item</Dropdown.Item>
</Dropdown.SubList>
</Dropdown.SubList>
</Dropdown.List>
),
}); const { overlay, getByText } = await setup({
overlay: (
<Dropdown.List textAlign="center">
<Dropdown.Item key="Item 1">Item 1</Dropdown.Item>
<Dropdown.Item key="Item 2">Item 2</Dropdown.Item>
<Dropdown.SubList key="Item 3" title="Sub List">
<Dropdown.Item key="1">Sub Item</Dropdown.Item>
<Dropdown.SubList
key="Overflow Sub List"
title="Overflow Sub List"
maxHeight="200px"
overflow="auto"
>
<Dropdown.Item key="1">Sub List Item</Dropdown.Item>
</Dropdown.SubList>
</Dropdown.SubList>
</Dropdown.List>
),
});
await new Promise(resolve => setTimeout(resolve, 0));There was a problem hiding this comment.
click 完 setTimeout 就壞了，太神啦
fireEvent.click(button);There was a problem hiding this comment.
There was a problem hiding this comment.
錯了 發現是後面那行的影響，這行可以把前面的 setTimeout 弄壞
await new Promise(resolve => setTimeout(resolve, 0));
await waitForElement(() => utils.queryByTestId(overlayTestId))
jigsawye
force-pushed
the
chore/bump-deps
branch
from
b9cbed3 to
6683d7c
Compare
jigsawye
force-pushed
the
chore/bump-deps
branch
from
6683d7c to
2c5d9c3
Compare
|
看起來測試過了？ |
| @@ -116,7 +116,8 @@ describe('Dropdown', () => { | |||
| expect(onDisabledItemClick).not.toBeCalled(); | |||
| }); | |||
|
|
|||
| it('should render subList when hover on Item and match snapshots', async () => { | |||
| // FIXME: test | |||
| it.skip('should render subList when hover on Item and match snapshots', async () => { | |||
There was a problem hiding this comment.
@chentsulin 教的 skip 大法好
There was a problem hiding this comment.
還是解到這裡，結論還是 setTimeout 壞了
setTimeout(runExpectation, 0);這行改成
runExpectation();就會過
setTimeout toString 是 jsdom 正常的 setTimeout 也不是 mock 的
There was a problem hiding this comment.
大神給跪了，那這樣要怎麼解決，發 PR 嗎
There was a problem hiding this comment.
還是無法解決XD
理論上
setTimeout(runExpectation, 0);應該也要正常的 resolve promise 然後 await 往下走，還是搞不懂 setTimeout 為啥沒用，所以也無法去發這個 PR
There was a problem hiding this comment.
或是把 tailor-ui 的 subset 做成 reproduce example 去發 issue 問他，只留 Dropdown 相關的 code 跟這個有問題的測試
There was a problem hiding this comment.
結果把 Dropdown 以外的東西都幹掉就過了
升個 react 16.8 alpha