chore: fallback react to 16.8-alpha.0 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jigsawye
force-pushed
the
chore/fallback-react-to-16.8-alpha.0
branch
from
9744ea9 to
b219e00
Compare
jigsawye
commented
Jan 30, 2019
| @@ -203,7 +204,7 @@ const Input: FunctionComponent<IInputProps> = forwardRef( | |||
| const inputRef = useRef<any>(null); | |||
|
|
|||
| // FIXME: wait for upstream: https://github.com/DefinitelyTyped/DefinitelyTyped/pull/32144 | |||
| (React as any).useImperativeHandle(ref, () => ({ | |||
| useImperativeMethods(ref, () => ({ | |||
jigsawye
commented
Jan 30, 2019
| @@ -42,15 +40,14 @@ export const TooltipContent = styled(tag.div)<TooltipContentProps>` | |||
| `}; | |||
|
|
|||
| ${space}; | |||
| ${minWidth}; | |||
There was a problem hiding this comment.
這個 breaking 但影響應該不大
jigsawye
commented
Jan 30, 2019
| @@ -34,6 +31,7 @@ export const TooltipContent = styled(tag.div)<TooltipContentProps>` | |||
| color: ${({ light, theme: { colors } }) => | |||
| light ? colors.gray700 : colors.light}; | |||
| font-size: ${p => p.theme.fontSizes.sm}; | |||
| white-space: nowrap; | |||
jigsawye
force-pushed
the
chore/fallback-react-to-16.8-alpha.0
branch
from
b219e00 to
f25d4ef
Compare
jigsawye
force-pushed
the
chore/fallback-react-to-16.8-alpha.0
branch
from
f25d4ef to
862fcf4
Compare
kpman
approved these changes
Jan 30, 2019
|
@kpman 他們作者說在重寫，以後不會用到這個 API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.