Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the statefulset's headless service from broker to kafka #315

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Rename the statefulset's headless service from broker to kafka #315

merged 1 commit into from
Apr 25, 2020

Conversation

solsson
Copy link
Contributor

@solsson solsson commented Apr 25, 2020

This allows DNS names to be used in args interpolation, for example:

      - name: broker
        env:
        - name: POD_NAME
          valueFrom:
            fieldRef:
              fieldPath: metadata.name
        args:
        - /etc/kafka/server.properties.$(POD_NAME)
        - --override
        -   listeners=PLAINTEXT://$(POD_NAME).kafka:9092

@solsson
Breaking: renames the statefulset's headless service so
ebc5042 
the pod name or statefulset.kubernetes.io/pod-name can be used via
the downward api in args to do things like
--override listeners=PLAINTEXT://$(POD_NAME).kafka:9092

Once again it's unfortunate that the statefulset label is pod name,
not pod index.

Also makes sure that DNS entries are published prior to readiness
so clusters don't get into loops of not being able to find each other.
@solsson solsson merged commit 2aef643 into nonroot-entrypoints Apr 25, 2020
@solsson solsson deleted the entrypoints-args-override-listeners-support branch April 25, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@solsson