Merge pull request Netflix#3779 from Young-Zen/ui-fix-validation-erro…

…r-handling Fix validation error handling in workflow/task editor
Young-Zen · Nov 10, 2023 · 2066bf9 · 2066bf9
1 parent b421076
commit 2066bf9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 8 deletions.
diff --git a/ui/src/pages/definition/SaveTaskDialog.jsx b/ui/src/pages/definition/SaveTaskDialog.jsx
@@ -49,11 +49,12 @@ export default function SaveTaskDialog({ onSuccess, onCancel, document }) {
     },
     onError: (err) => {
       console.log("onerror", err);
-      let errStr = _.isString(err.body)
-        ? err.body
-        : JSON.stringify(err.body, null, 2);
+      const errObj = JSON.parse(err);
+      let errStr = errObj.validationErrors && errObj.validationErrors.length > 0
+        ? `${errObj.validationErrors[0].message}: ${errObj.validationErrors[0].path}`
+        : errObj.message;
       setErrorMsg({
-        message: `${TASK_SAVE_FAILED}: ${errStr}`,
+        message: `${TASK_SAVE_FAILED} ${errStr}`,
         dismissible: true,
       });
     },

diff --git a/ui/src/pages/definition/SaveWorkflowDialog.jsx b/ui/src/pages/definition/SaveWorkflowDialog.jsx
@@ -81,10 +81,11 @@ export default function SaveWorkflowDialog({ onSuccess, onCancel, document }) {
     },
     onError: (err) => {
       console.log("onerror", err);
-      let errStr = _.isString(err.body)
-        ? err.body
-        : JSON.stringify(err.body, null, 2);
-      setErrorMsg(`${WORKFLOW_SAVE_FAILED}: ${errStr}`);
+      const errObj = JSON.parse(err);
+      let errStr = errObj.validationErrors && errObj.validationErrors.length > 0
+        ? `${errObj.validationErrors[0].message}: ${errObj.validationErrors[0].path}`
+        : errObj.message;
+      setErrorMsg(`${WORKFLOW_SAVE_FAILED} ${errStr}`);
     },
   });