Support for Bio Multi-protocol keys #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamVe
requested changes
Jun 24, 2024
YubiKit/YubiKit/Connections/Shared/Sessions/MGMT/YKFManagementSession.h
Outdated
Show resolved
Hide resolved
Comment on lines
1
to
7
| // | ||
| // YKFInvalidPinError.h | ||
| // YubiKit | ||
| // | ||
| // Created by Jens Utbult on 2024-06-19. | ||
| // Copyright © 2024 Yubico. All rights reserved. | ||
| // |
There was a problem hiding this comment.
I saw in other files you update this to a different header, maybe you forgot here?
Comment on lines
1
to
7
| // | ||
| // YKFInvalidPinError.m | ||
| // YubiKit | ||
| // | ||
| // Created by Jens Utbult on 2024-06-19. | ||
| // Copyright © 2024 Yubico. All rights reserved. | ||
| // |
There was a problem hiding this comment.
This header is different than in other files.
Comment on lines
957
to
964
| int retries = [self getRetriesFromStatusCode:(int)error.code]; | ||
| if (retries >= 0) { | ||
| completion([YKFInvalidPinError invalidPinErrorWithRetries:retries]); | ||
| return; | ||
| } else { | ||
| completion(error); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Review this part - if verification of the temporary PIN fails, the error.code will be 0x63C0, so there is no need to get the retries.
dainnilsson
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.