fix lint

YukiOnishi1129 · Jun 21, 2024 · 0104918 · 0104918
1 parent 913efa5
commit 0104918
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 11 deletions.
diff --git a/batch-service/infrastructure/supabase/repository/article.go b/batch-service/infrastructure/supabase/repository/article.go
@@ -44,11 +44,7 @@ func (ar *ArticleRepository) GetArticles(ctx context.Context, dto domain.GetArti
 	if err != nil {
 		return nil, err
 	}
-	articles := make([]*entity.Article, len(aRows))
-	for i, a := range aRows {
-		articles[i] = a
-	}
-	return articles, nil
+	return aRows, nil
 }
 
 // func (ar *ArticleRepository) GetArticles(ctx context.Context, dto domain.GetArticlesInputDTO) ([]domain.Article, error) {

diff --git a/batch-service/internal/crawler/article_contents_crawler_test.go b/batch-service/internal/crawler/article_contents_crawler_test.go
@@ -2,6 +2,7 @@ package crawler
 
 import (
 	"context"
+	"database/sql"
 	"testing"
 	"time"
 
@@ -240,7 +241,7 @@ func Test_Internal_ArticleContentsCrawler(t *testing.T) {
 
 			if tt.recordPlatform != nil {
 				for _, v := range tt.recordPlatform {
-					err := v.Insert(ctx, db, boil.Infer())
+					err = v.Insert(ctx, db, boil.Infer())
 					if err != nil {
 						t.Fatalf("Failed to insert record: %s", err)
 					}
@@ -249,7 +250,7 @@ func Test_Internal_ArticleContentsCrawler(t *testing.T) {
 
 			if tt.recordCategories != nil {
 				for _, v := range tt.recordCategories {
-					err := v.Insert(ctx, db, boil.Infer())
+					err = v.Insert(ctx, db, boil.Infer())
 					if err != nil {
 						t.Fatalf("Failed to insert record: %s", err)
 					}
@@ -258,7 +259,7 @@ func Test_Internal_ArticleContentsCrawler(t *testing.T) {
 
 			if tt.recordFeeds != nil {
 				for _, v := range tt.recordFeeds {
-					err := v.Insert(ctx, db, boil.Infer())
+					err = v.Insert(ctx, db, boil.Infer())
 					if err != nil {
 						t.Fatalf("Failed to insert record: %s", err)
 					}
@@ -267,7 +268,7 @@ func Test_Internal_ArticleContentsCrawler(t *testing.T) {
 
 			if tt.recordArticles != nil {
 				for _, v := range tt.recordArticles {
-					err := v.Insert(ctx, db, boil.Infer())
+					err = v.Insert(ctx, db, boil.Infer())
 					if err != nil {
 						t.Fatalf("Failed to insert record: %s", err)
 					}
@@ -276,7 +277,7 @@ func Test_Internal_ArticleContentsCrawler(t *testing.T) {
 
 			if tt.recordFeedArticleRelations != nil {
 				for _, v := range tt.recordFeedArticleRelations {
-					err := v.Insert(ctx, db, boil.Infer())
+					err = v.Insert(ctx, db, boil.Infer())
 					if err != nil {
 						t.Fatalf("Failed to insert record: %s", err)
 					}
@@ -287,7 +288,12 @@ func Test_Internal_ArticleContentsCrawler(t *testing.T) {
 			if err != nil {
 				t.Fatalf("Failed to begin transaction: %s", err)
 			}
-			defer tx.Rollback()
+			defer func(tx *sql.Tx) {
+				err = tx.Rollback()
+				if err != nil {
+					t.Fatalf("Failed to rollback transaction: %s", err)
+				}
+			}(tx)
 
 			res, err := ArticleContentsCrawler(ctx, tx, tt.feed, tt.rss, tt.isEng)
 			if err != nil {