fixed typechecks

YulNaumenko · Aug 24, 2021 · 6f6770f · 6f6770f
1 parent 041243a
commit 6f6770f
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 0 deletions.
diff --git a/x-pack/plugins/alerting/server/routes/find_rules.ts b/x-pack/plugins/alerting/server/routes/find_rules.ts
@@ -77,6 +77,7 @@ const rewriteBodyRes: RewriteResponseCase<FindResult<AlertTypeParams>> = ({
         executionStatus,
         actions,
         scheduledTaskId,
+        legacyId,
         ...rest
       }) => ({
         ...rest,
@@ -86,6 +87,7 @@ const rewriteBodyRes: RewriteResponseCase<FindResult<AlertTypeParams>> = ({
         created_at: createdAt,
         updated_at: updatedAt,
         api_key_owner: apiKeyOwner,
+        legacy_id: legacyId,
         notify_when: notifyWhen,
         mute_all: muteAll,
         muted_alert_ids: mutedInstanceIds,

diff --git a/x-pack/plugins/alerting/server/routes/legacy/create.test.ts b/x-pack/plugins/alerting/server/routes/legacy/create.test.ts
@@ -40,6 +40,7 @@ describe('createAlertRoute', () => {
       bar: true,
     },
     throttle: '30s',
+    legacyId: null,
     notifyWhen: 'onActionGroupChange',
     actions: [
       {

diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/create.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/create.ts
@@ -82,6 +82,7 @@ export default function createAlertTests({ getService }: FtrProviderContext) {
         consumer: 'alertsFixture',
         params: {},
         created_by: null,
+        legacy_id: null,
         schedule: { interval: '1m' },
         scheduled_task_id: response.body.scheduled_task_id,
         updated_by: null,
@@ -318,6 +319,7 @@ export default function createAlertTests({ getService }: FtrProviderContext) {
           scheduledTaskId: response.body.scheduledTaskId,
           updatedBy: null,
           apiKeyOwner: null,
+          legacyId: null,
           throttle: '1m',
           notifyWhen: 'onThrottleInterval',
           muteAll: false,

diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/find.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/find.ts
@@ -59,6 +59,7 @@ export default function createFindTests({ getService }: FtrProviderContext) {
         actions: [],
         params: {},
         created_by: null,
+        legacy_id: null,
         api_key_owner: null,
         scheduled_task_id: match.scheduled_task_id,
         updated_by: null,
@@ -145,6 +146,7 @@ export default function createFindTests({ getService }: FtrProviderContext) {
           actions: [],
           params: {},
           createdBy: null,
+          legacyId: null,
           apiKeyOwner: null,
           scheduledTaskId: match.scheduledTaskId,
           updatedBy: null,

diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/get.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/get.ts
@@ -43,6 +43,7 @@ export default function createGetTests({ getService }: FtrProviderContext) {
         actions: [],
         params: {},
         created_by: null,
+        legacy_id: null,
         scheduled_task_id: response.body.scheduled_task_id,
         updated_by: null,
         api_key_owner: null,
@@ -108,6 +109,7 @@ export default function createGetTests({ getService }: FtrProviderContext) {
           actions: [],
           params: {},
           createdBy: null,
+          legacyId: null,
           scheduledTaskId: response.body.scheduledTaskId,
           updatedBy: null,
           apiKeyOwner: null,

diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/update.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/update.ts
@@ -54,6 +54,7 @@ export default function createUpdateTests({ getService }: FtrProviderContext) {
         enabled: true,
         updated_by: null,
         api_key_owner: null,
+        legacyId: null,
         mute_all: false,
         muted_alert_ids: [],
         notify_when: 'onThrottleInterval',
@@ -142,6 +143,7 @@ export default function createUpdateTests({ getService }: FtrProviderContext) {
           enabled: true,
           updatedBy: null,
           apiKeyOwner: null,
+          legacyId: null,
           muteAll: false,
           mutedInstanceIds: [],
           notifyWhen: 'onThrottleInterval',