Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appearance() break the colors in all the app in which the library is added #430

Closed
gaetano78 opened this issue Dec 12, 2019 · 2 comments
Closed
Assignees
Labels
Bug This is clearly a bug and will be fixed in priority

Comments

@gaetano78
Copy link

In the file YImagePicker.swift, the lines:

if UINavigationBar.appearance().tintColor == nil {
UINavigationBar.appearance().tintColor = .black
}

Break the UI of my app, as the line "UINavigationBar.appearance().tintColor = .black" change the color of backbutton in all my navigation controllers. I think you should not use appearance, as it is a global things. In my case, I just commented the line and made some changes to my code, but commenting the line could not be the solution in every case.

Thanks anyway for the wonderful library!

Thanks

@s4cha s4cha added the Bug This is clearly a bug and will be fixed in priority label Jan 9, 2020
@s4cha s4cha self-assigned this Jan 9, 2020
@s4cha
Copy link
Member

s4cha commented Jan 9, 2020

@gaetano78 thanks a ton for reporting this serious issue 🙏. Will let you know once a fix is issued

@s4cha s4cha closed this as completed in 15119f1 Jan 9, 2020
@s4cha
Copy link
Member

s4cha commented Jan 9, 2020

Kaelzs pushed a commit to iftechio/YPImagePicker that referenced this issue Feb 11, 2020
LucasDang pushed a commit to pukapp/secret-ios-YPImagePicker that referenced this issue Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is clearly a bug and will be fixed in priority
Projects
None yet
Development

No branches or pull requests

2 participants