Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not escape ( #25

Merged

Conversation

inez
Copy link
Contributor

@inez inez commented Oct 23, 2020

No description provided.

@YusukeIwaki
Copy link
Owner

Hi, thank you for your contribution :)

@YusukeIwaki YusukeIwaki merged commit c7eeadc into YusukeIwaki:master Oct 26, 2020
YusukeIwaki added a commit that referenced this pull request Oct 26, 2020
@YusukeIwaki
Copy link
Owner

YusukeIwaki commented Oct 26, 2020

@inez puppeteer-ruby 0.0.21 includes this fix. Thank you :)

gus-bn pushed a commit to thegurucompany/puppeteer-ruby that referenced this pull request Dec 18, 2020
* Do not escape (

* add RSpec for YusukeIwaki/pull/25

* 0.0.20 -> 0.0.21

* show warning on error in "#future"

* fix Puppeteer#product to work

* add RSpec: launcher spec

* 0.0.21 -> 0.0.22

* add Docker guide

resolves YusukeIwaki#28

* enforce parentheses for method calls

* implement Events constant

* remove unused internal-only events

* define on and once in EventCallbackable

* remove Events class.

* fix RuboCop warnings

* Revert "Remove ugly logic in CDPSession."

This reverts commit 675b01e.

* fix comment

* Revert "Revert deletion of workaround for unordered SEND/RECV "

* Consider 'handle_message' is called just after 'send_text' before returning raw_send.

* implement Page#geolocation= and BrowserContext#override_permissions

* fix LifecycleWatcher to respect the timeout parameter

* add RSpec: page_spec

* 0.0.22 -> 0.0.23

* add cookies feature

* addType: CookieData

* skip some specs for Firefox

* 0.0.23 -> 0.0.24

* Revert "addType: CookieData"

This reverts commit f17639a.

* 0.0.24 -> 0.0.25

* Create CHANGELOG.md

Co-authored-by: Inez Korczynski <inez@squareup.com>
Co-authored-by: Yusuke Iwaki <iwaki@i3-systems.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants