Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(New NPM package and version) Make necessary upgrades and changes for Material-UI v5 #314

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ShotSkydiver
Copy link

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

Using in my live website

Test Configuration:

  • Browser: Safari 15 beta

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ShotSkydiver ShotSkydiver marked this pull request as ready for review July 14, 2021 23:19
@TobyOoO
Copy link

TobyOoO commented Jul 20, 2021

Hope this PR to be merged and get released soon.

@ShotSkydiver
Copy link
Author

ShotSkydiver commented Jul 27, 2021

It should be good to go! I hope it gets merged soon too!

@TobyOoO
Copy link

TobyOoO commented Jul 28, 2021

Somehow when I tested it locally with latest material-ui v5, I have to specify default theme and pass theme argument to make it workable.

@SoaresMG
Copy link

Any ETA on this?

@ShotSkydiver
Copy link
Author

ShotSkydiver commented Sep 3, 2021

Just updated this to support the just-released material-ui v5 RC-0, and the package naming changes that come along with that (from @material-ui to @mui)

@Maxastuart
Copy link

@ShotSkydiver This is great work, incredibly needed, and I'm afraid after poking around that @Yuvaleros (the only person with write-access here) is not likely active on GH any longer. Can you publish a new package to NPM from the fork in your account? (Maybe named material-ui-dropzone-v5?)

@ShotSkydiver
Copy link
Author

@ShotSkydiver This is great work, incredibly needed, and I'm afraid after poking around that @Yuvaleros (the only person with write-access here) is not likely active on GH any longer. Can you publish a new package to NPM from the fork in your account? (Maybe named material-ui-dropzone-v5?)

Yeah for sure! I'll do that today, and post the new package link here.

@ShotSkydiver
Copy link
Author

New NPM package is live! I ended up scoping it to my NPM username since all unscoped names were seemingly already taken 🙃 New package name to install is @shotskydiver/material-ui-dropzone and the new version will install as v4.0.2! From now on I'll be semi-occasionally maintaining and contributing to this new package, so for anyone wanting to use this package, it now lives (I guess) under the name @shotskydiver/material-ui-dropzone at the repo https://github.com/ShotSkydiver/material-ui-dropzone! Contributions are extremely welcome!

@ShotSkydiver ShotSkydiver changed the title Make necessary upgrades and changes for Material-UI v5 (New NPM package and version) Make necessary upgrades and changes for Material-UI v5 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants