use TextDocument from vscode-languageserver-textdocument #17
+5,969
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
suggested changes
Apr 21, 2021
There was a problem hiding this comment.
- You should remove the
.idea/*files from this PR. I recommend setting up a globalcores.excludesfileto ignore.ideain all Git repository, see: https://stackoverflow.com/a/7335487 - This repository uses yarn v1, so you should add the dependency via
yarn add -D vscode-languageserver-textdocumentand remove thepackage-lock.jsonfile from this PR. - You should remove the space in front of
Diagnosticin theindex.tsimport.
| @@ -1,5 +1,7 @@ | |||
| import * as path from "path"; | |||
| import { TextDocument, Diagnostic } from "vscode-languageserver"; | |||
| import { Diagnostic } from "vscode-languageserver"; | |||
There was a problem hiding this comment.
Suggested change
| import { Diagnostic } from "vscode-languageserver"; | |
| import { Diagnostic } from "vscode-languageserver"; |
Yuyz0112
requested changes
Apr 21, 2021
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
shall we git ignore idea files since it's editor related
There was a problem hiding this comment.
It probably makes sense to use the gitignore file of another project like Vue as a template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import { TextDocument } from "vscode-languageserver";
TextDocument has been deprecated in vscode-languageserver
So,We should use
import { TextDocument} from "vscode-languageserver-textdocument";