Skip to content

Commit

Permalink
Drop explicit MSVC's DYNAMICBASE option setting in favour of defaults
Browse files Browse the repository at this point in the history
This option is not supported on Arm64 and the defaults should be fine
  • Loading branch information
janisozaur authored and NikolajBjorner committed Oct 24, 2019
1 parent 837651e commit 907ffde
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions cmake/msvc_legacy_quirks.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -169,17 +169,6 @@ foreach (_build_type ${_build_types_as_upper})
string(APPEND CMAKE_EXE_LINKER_FLAGS_${_build_type} " /TLBID:1")
string(APPEND CMAKE_SHARED_LINKER_FLAGS_${_build_type} " /TLBID:1")

# FIXME: This is not necessary. This is MSVC's default.
# Address space layout randomization
# See https://msdn.microsoft.com/en-us/library/bb384887.aspx
string(APPEND CMAKE_EXE_LINKER_FLAGS_${_build_type} " /DYNAMICBASE")
if(ENABLE_CFI)
# CFI requires /DYNAMICBASE to be enabled.
string(APPEND CMAKE_SHARED_LINKER_FLAGS_${_build_type} " /DYNAMICBASE")
else()
string(APPEND CMAKE_SHARED_LINKER_FLAGS_${_build_type} " /DYNAMICBASE:NO")
endif()

# FIXME: This is not necessary. This is MSVC's default.
# Indicate that the executable is compatible with DEP
# See https://msdn.microsoft.com/en-us/library/ms235442.aspx
Expand Down

0 comments on commit 907ffde

Please sign in to comment.