Link pthread using the --whole-archive option #2683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolajBjorner
added a commit
that referenced
this pull request
Nov 6, 2019
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
fpoli
force-pushed
the
fix-static-linking
branch
from
537e07c
to
ec259b5
Compare
|
shouldn't it depend on is_static_bin/is_static_lib? |
Ah, yes. Maybe also on |
This fixes a SIGSEGV on Ubuntu 16.04 when running z3 compiled with `--staticbin` (issue Z3Prover#2457). It seems that without the --whole-archive option the linker does not statically link all pthread symbols. The fix is described here: https://stackoverflow.com/a/45271521/2491528
fpoli
force-pushed
the
fix-static-linking
branch
from
ec259b5
to
7eb6731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a SIGSEGV on Ubuntu 16.04 when running z3 compiled with
--staticbin(issue #2457). It seems that without the--whole-archiveoption the linker does not statically link all pthread symbols.The fix is described here: https://stackoverflow.com/a/45271521/2491528
Note: also
SLINK_EXTRA_FLAGSprovides a-lpthread, but I haven't modified it because I'm not sure how it's used.