z3str3: fix support for re.complement and re.intersection #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copumpkin
reviewed
Apr 24, 2020
| return false; | ||
| } else if (u.re.is_intersection(re)) { | ||
| return false; | ||
| } else if (u.re.is_complement(re)) { |
There was a problem hiding this comment.
I think this one is redundant given the one right above isn't it?
There was a problem hiding this comment.
You're right, but eventually, these will have two different heuristics for length, and I wanted to capture that by separating them out.
|
feel free to merge when it is ready on your side |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug reported to me off-tracker where instances containing regex complement and intersection operators would crash unexpectedly when run using Z3str3. Thanks to @copumpkin for the report!