z3str3: remove legacy code #4215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parameter smt.str.fixed_length_overlap_models has been deprecated
…h heuristic the following parameters are deprecated: smt.str.use_binary_search smt.str.binary_search_start smt.str.fixed_length_models (the fixed-length model construction is now always used)
|
As a result of this patch, the following parameters are deprecated:
|
hgvk94
pushed a commit
to hgvk94/z3
that referenced
this pull request
May 7, 2020
* z3str3: remove legacy fixed-length overlap testing parameter smt.str.fixed_length_overlap_models has been deprecated * z3str3: remove legacy length/value testing algorithm and binary search heuristic the following parameters are deprecated: smt.str.use_binary_search smt.str.binary_search_start smt.str.fixed_length_models (the fixed-length model construction is now always used) * z3str3: remove legacy regex unroll methods * z3str3: remove unused methods and member variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch removes a large amount of legacy code from
theory_str, including:This code has been superseded by newer modules with better performance and is prone to errors. It also won't be maintained going forward. All of the associated code has been disabled by default for a very long time and enabling it isn't the recommended way to invoke Z3str3.