Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NuGet package name and glibc rid. #5290

Merged
merged 1 commit into from
May 21, 2021
Merged

Fix NuGet package name and glibc rid. #5290

merged 1 commit into from
May 21, 2021

Conversation

Choc13
Copy link
Contributor

@Choc13 Choc13 commented May 21, 2021

No description provided.

@Choc13
Copy link
Contributor Author

Choc13 commented May 21, 2021

@NikolajBjorner thanks for merging #5288. I managed to test this locally by downloading the NuGet from the nightly release on here. It works fine for Mac. However, I noticed that the deps.json for the linux lib was now showing as glibc-x64, which isn't a valid linux RID according to here. I also asked a colleague on Linux to try the nightly and it broke for him.

I think this is possibly only an issue in the nightlies because it's just in mk_nuget_task.py that it mentions glibc-x64.

Second to this I noticed that the NuGet package name had changed to Microsoft.Z3 instead of being Microsoft.Z3.x64. If this was intentional then apologies and I can revert that.

@NikolajBjorner
Copy link
Contributor

NikolajBjorner commented May 21, 2021

Thanks for checking up on the ubuntu vs glibc. It was introduced when our hosted build machines started using this naming convention so I assumed it was a Linux-wide convention change.

For x64: the reason is that someone took ownership of the nuget package Microsoft.Z3 namespace and the party didn't respond to releasing the name for some time as I was setting up a native distribution pipeline.
I believe now it was revoked and can be used by z3 distributions. We can try with removing the x64 suffix which is by now misleading given the requirement by Don to add the x86 Windows.

Also, the nightly builds are rehearsals for releases. So the conventions used in releases will be the same.
Releases upload to nuget, which will likely break next time, but it is a finite process to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants