-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmake setup.py build dep #5972
Add cmake setup.py build dep #5972
Conversation
I am unclear about the implications: |
Pip will attempt to do the follwing:
To check this, here is a
Here is the result of me building this:
As you can see, |
oh grief |
This extends #5971
It additionally adds
cmake
as a pip-installable build dependency.cmake
is a native dependency, however, pip has a very well (first party?) maintainedcmake
package. This PR would tell the unbuiltz3-solver
python
package to depend on pypy'scmake
; that is,pip install z3-solver
willpip install cmake
during build time as needed.This would have a few benefits:
pip install z3-solver
will no longer fail ifcmake
is not present on the host system. This can be useful in docker, for example, among other scenarios.Note: This is not (necessarily) a bug fix, but a feature add. It just makes it easier to build in isolated environments, improves the chances of build success / reproducibility, and prefers using the python package manager for distributing packages the python package manager has over leaving installing it to the user natively.