Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MANIFEST.in will now include pyproject.toml #5979

Merged

Conversation

zwimer
Copy link
Contributor

@zwimer zwimer commented Apr 13, 2022

This change should ensure that even if your CI is older, the generated sdist z3 publishes to pypi should include pyproject.toml. This should ensure that pyproject.toml is distributed with the pip sdist, thus whenever pip builds the z3 wheel it should honor build dependencies if the user's software is new enough. If their software is too outdated this just adds a couple extra bytes to the size of the package but should otherwise be ignored.

Tested via:

FROM alpine
RUN apk add --no-cache make g++ python3 py3-pip git
RUN pip install --upgrade pip

# Clone
RUN git clone --depth 1 https://github.com/Z3Prover/z3 /z3
WORKDIR /z3/src/api/python

# Add change
RUN echo "include pyproject.toml" >> MANIFEST.in

# Gen sdist
RUN python3 setup.py sdist
WORKDIR dist

# Build pip install from sdist to mimic pip install from pypy sdist
RUN tar -xvf *; rm -rf *.gz; mv * dir
WORKDIR dir
RUN pip install .

@NikolajBjorner NikolajBjorner merged commit 9ecd4f8 into Z3Prover:master Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants