wasm build: disable error handler #5996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default error handler calls
exit, which makes the wasm API hang. So this PR makes the error handler for the wasm build do nothing, like in the Python API.Also, in the second commit, separates out the fancy typescript wrapper from the emscripten artifact (and adds a new script which joins the two, for node consumers), so that a web build can link against the typescript wrapper without including the emscripten artifact, which needs to be served separately.
Fixes #5995, I believe. cc @ViRb3, can you try out this branch? See in particular the updated instructions in the readme, which should make it so you don't need the
Module['mainScriptUrlOrBlob']bit. I have a copy here built with this fork which seems to work correctly.