fix z3str3 re.is_range symbolic argument bug #6186
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolajBjorner
added a commit
that referenced
this pull request
Jul 22, 2022
Signed-off-by: Nikolaj Bjorner <nbjorner@microsoft.com>
| @@ -768,7 +772,11 @@ namespace smt { | |||
| return _qmul(2, cx); | |||
| } else if (u.re.is_range(re, sub1, sub2)) { | |||
| SASSERT(u.str.is_string(sub1)); | |||
| if (!u.str.is_string(sub1)) | |||
There was a problem hiding this comment.
Why introduce 3 copies of essentially the same code three different places?
I have added a routine now u.re.is_range(re, ch1, ch2), it returns true if re is a regex range with singleton character bounds. ch1, ch2 are unsigned integers (character codes).
There was a problem hiding this comment.
Hi I have modified the code using u.re.is_range(re, ch1, ch2) in #6189 .
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Z3str3 doesn't support re.is_range symbolic arguments.