Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create parent directories of SourceFile #189

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Create parent directories of SourceFile #189

merged 1 commit into from
Oct 24, 2023

Conversation

BraisGabin
Copy link

@BraisGabin BraisGabin commented Oct 18, 2023 •
edited
Loading

This is just a cherry-pick from this PR: tschuchortdev#339

Fixes #188

Original message:

Currently, createNewFile() fails if you have a SourceFile in a directory, since it can't create the owning directory.

@pranjalvachaspati-toast @BraisGabin
Create parent directories of SourceFile. (tschuchortdev#339)
134ce9c 
Currently, createNewFile() fails if you have a SourceFile in a directory,
since it can't create the owning directory.
ZacSweers
ZacSweers approved these changes Oct 24, 2023
View reviewed changes
Copy link
Owner

@ZacSweers ZacSweers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We should switch to Path, which has some nice newer APIs for this

@ZacSweers ZacSweers merged commit fdaa9da into ZacSweers:main Oct 24, 2023
2 checks passed
@BraisGabin BraisGabin deleted the directory-sourcefile branch October 25, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacSweers ZacSweers ZacSweers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SourceFile inside folders
3 participants
@BraisGabin @ZacSweers @pranjalvachaspati-toast