Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function "getOversampling()" to read the oversampling values from the BME680 #17

Closed
SV-Zanshin opened this issue May 25, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@SV-Zanshin
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

I have had a request to add this function to the library, at the moment the library contains no means of reading the current settings.

Describe the solution you'd like
Add the "getOversampling()" function to the library with the same parameters as the setOversampling() function.

Describe alternatives you've considered
None, if the user wants to read the current settings.

Additional context
None required

Zanshin Logo

@SV-Zanshin SV-Zanshin added the enhancement New feature or request label May 25, 2020
@SV-Zanshin SV-Zanshin self-assigned this May 25, 2020
@SV-Zanshin
Copy link
Collaborator Author

I think that the routine should be modified along the lines of the setIIRFilter() function. Right now the return value is a boolean for success or failure, but this can be changed to an unsigned integer returning the current setting. When called with no parameter for the setting, it will return the register contents.

While this is nominally not backwards compatible to the current implementation, it makes sense to change the functionality and documentation.

SV-Zanshin pushed a commit that referenced this issue May 25, 2020
@SV-Zanshin
Copy link
Collaborator Author

Changed functionality of teh "setOversampling()" function and updated the documentation.

@SV-Zanshin SV-Zanshin mentioned this issue May 27, 2020
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant