Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "clang-format" to format c++ using a standard style #25

Closed
SV-Zanshin opened this issue Jun 28, 2020 · 2 comments
Closed

Implement "clang-format" to format c++ using a standard style #25

SV-Zanshin opened this issue Jun 28, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@SV-Zanshin
Copy link
Collaborator

Describe what the feature request is and if it solves an issue or adds functionality
Currently the formatting of the library and example programs is non-standard. Using a standardized tool such as "clang-format" allows for a more legible source code and makes applying pull requests from multiple contributors much easier

Describe the solution you'd like
Add "clang-format" to the GitHub actions to automatically format on commit

Describe alternatives you've considered
none

Additional context
While I like working on a wide screen with the current 120-column width, it is non-standard.

@SV-Zanshin SV-Zanshin added the enhancement New feature or request label Jun 28, 2020
@SV-Zanshin SV-Zanshin self-assigned this Jun 28, 2020
@SV-Zanshin
Copy link
Collaborator Author

Started converting the existing source code. This takes some time, because of the previous formatting.
Changed "SDLoggerSPIDemo.ino" and the library header file "Zanshin_BME680.h" files in the development branch so far

SV-Zanshin pushed a commit that referenced this issue Jul 5, 2020
Changed source to adhere to "clang-format" with Google standards
@SV-Zanshin
Copy link
Collaborator Author

Changed the library and example programs to adhere to standard Google formatting using clang-format with a width of 100

SV-Zanshin pushed a commit that referenced this issue Jul 5, 2020
Implement automated clang-format checking using Travis-CI
SV-Zanshin pushed a commit that referenced this issue Jul 5, 2020
SV-Zanshin pushed a commit that referenced this issue Jul 5, 2020
Updated web page header comments for clang-format
SV-Zanshin pushed a commit that referenced this issue Jul 5, 2020
@SV-Zanshin SV-Zanshin mentioned this issue Sep 27, 2020
16 tasks
SV-Zanshin pushed a commit that referenced this issue Sep 27, 2020
* Updated version to v1.0.8

* Updated to v1.0.9

* Work on standardized c++ formatting

Added a .clang-format file and started using "clang-format" with Google style formatting.  The only difference is that the columns are 100 instead of 80 wide

* Updated file to adhere to clang-format conventions

* Correct documentation

* Issue #25

Changed source to adhere to "clang-format" with Google standards

* Issue #25

Implement automated clang-format checking using Travis-CI

* Issue #25

* Issue #25

Updated web page header comments for clang-format

* Changes for Issue #25

* Update to let esp8266 travis work

* clang-format changes

* Issue #26 - corrected gas resistance variables in computation

* CLANG-Formatted document

* Issue #26 - corrected pressure computation

* Corrected CLANG-Format

* Issue #26

Added return status for getSensorData() function

* CLANG-Format changes
SV-Zanshin pushed a commit that referenced this issue Sep 27, 2020
* Updated version to v1.0.8

* Updated to v1.0.9

* Work on standardized c++ formatting

Added a .clang-format file and started using "clang-format" with Google style formatting.  The only difference is that the columns are 100 instead of 80 wide

* Updated file to adhere to clang-format conventions

* Correct documentation

* Issue #25

Changed source to adhere to "clang-format" with Google standards

* Issue #25

Implement automated clang-format checking using Travis-CI

* Issue #25

* Issue #25

Updated web page header comments for clang-format

* Changes for Issue #25

* Update to let esp8266 travis work

* clang-format changes

* Issue #26 - corrected gas resistance variables in computation

* CLANG-Formatted document

* Issue #26 - corrected pressure computation

* Corrected CLANG-Format

* Issue #26

Added return status for getSensorData() function

* CLANG-Format changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant