Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal feature for validate_num_of_signers #740

Merged

Conversation

StackOverflowExcept1on
Copy link
Contributor

Resolves #736

@mpguerra mpguerra requested a review from conradoplg October 1, 2024 13:23
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.50%. Comparing base (5f4ac6e) to head (3d9fdb4).
Report is 50 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
- Coverage   82.18%   81.50%   -0.69%     
==========================================
  Files          31       34       +3     
  Lines        3188     3287      +99     
==========================================
+ Hits         2620     2679      +59     
- Misses        568      608      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@conradoplg
Copy link
Contributor

Thanks. This is failing CI but it's an unrelated issue that we'll sort out.

Copy link
Contributor

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@mergify mergify bot merged commit 30977f6 into ZcashFoundation:main Oct 2, 2024
17 checks passed
@StackOverflowExcept1on StackOverflowExcept1on deleted the validate_num_of_signers branch October 2, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add internal feature for validate_num_of_signers
2 participants