Depend on a tokio commit with the time wheel panic fix #1511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the tokio dependency to the commit that merged tokio-rs/tokio#3229, which should fix the time wheel panic in ZcashFoundation#1452.
teor2345
added
C-bug
This was referenced Dec 14, 2020
dconnolly
approved these changes
Dec 14, 2020
Closed
|
I've been running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tokio 0.3.4 and 0.3.5 have a bug tokio-rs/tokio#2789 that causes time wheel panics.
Solution
Updates the tokio dependency to the commit that merged tokio-rs/tokio#3229, which should fix the time wheel panic.
Testing:
Review
@dconnolly likes dependencies, but anyone can review.
Related Issues
Closes #1452.
Follow Up Work
Remove git dependencies in #1086.