-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): update ecc dependencies for zcashd
5.6.0, and create legacy state format compatibility layer
#7053
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…zation in orchard and sapling trees
I was able to make some progress by using some of the read/write functions from There are several things pending, some of them are:
Sapling:
Orchard:
Shows that the serialization is a bit longer. This seems to be because the Will post more details as i discover them. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Let's try to wrap up this PR so we can unblock the following work. If there is any other work that would be nice to have, let's create separate PRs for it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved the remaining dependency updates to ticket #6638, which is now a release blocker
zcashd
5.6.0, and create legacy state format compatibility layer
Motivation
Update ecc dependencies.
Close #6859
Depends-On: #7158
Solution
Create legacy code ion order to keep serialization the same as it was.
Review
@teor2345 and @conradoplg . There was already a lot of discussion about the options, solutions, etc.
Reviewer Checklist
Follow Up Work