-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(devops): Reduce number of dependabot PRs #7156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-dependencies
Area: Dependency file updates
A-devops
Area: Pipelines, CI/CD and Dockerfiles
P-Medium ⚡
I-cost
Zebra infrastructure costs
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Jul 5, 2023
upbqdn
reviewed
Jul 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for creating the groups.
upbqdn
previously approved these changes
Jul 8, 2023
Co-authored-by: Marek <mail@marek.onl>
@Mergifyio update |
✅ Branch has been successfully updated |
upbqdn
approved these changes
Jul 9, 2023
I think I tried to fix this in PR #7158, some of the auto-label settings are too much 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-dependencies
Area: Dependency file updates
A-devops
Area: Pipelines, CI/CD and Dockerfiles
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-cost
Zebra infrastructure costs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We're getting a lot of dependabot PRs, but some of them don't have a meaningful amount of changes. Others need to be grouped to pass CI.
Close #6547
Specifications
https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups
Complex Code or Requirements
We can update the groups later if they turn out not to work.
Solution
2 * (reviewers - 1)
, because often someone is away or busyTesting
Review
Let's try this and see how it goes?
Reviewer Checklist
Follow Up Work
Gustavo (or someone else) might want to group related GitHub Actions dependency updates, but I'm not sure what those groups should be.