Pr/add topicname args to navigation launch melodic #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjds
reviewed
Feb 21, 2020
| @@ -11,7 +11,8 @@ | |||
| <arg name="move_base_include" default="$(find fetch_navigation)/launch/include/move_base.launch.xml" /> | |||
| <arg name="amcl_include" default="$(find fetch_navigation)/launch/include/amcl.launch.xml" /> | |||
|
|
|||
| <!-- set topics for move_base --> | |||
| <!-- set topics --> | |||
| <arg name="scan_topic" default="base_scan" /> | |||
There was a problem hiding this comment.
Can you not use tab spacing here?
narora1
reviewed
Feb 21, 2020
| @@ -11,6 +11,12 @@ | |||
| <arg name="move_base_include" default="$(find fetch_navigation)/launch/include/move_base.launch.xml" /> | |||
| <arg name="amcl_include" default="$(find fetch_navigation)/launch/include/amcl.launch.xml" /> | |||
|
|
|||
| <!-- set topics --> | |||
| <arg name="scan_topic" default="base_scan" /> | |||
There was a problem hiding this comment.
here as well, don't use tab
cjds
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
melodic version of #137
I have not test this PR with melodic robot yet because we dont have a Fetch with melodic.