Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SeedRecovery: fix uneven columns and margins #2481

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

kaloudis
Copy link
Contributor

Description

Before:
Simulator Screenshot - iPhone 16 - 2024-10-21 at 18 52 37
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-21 at 18 57 45
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-21 at 18 57 54

After:
Simulator Screenshot - iPhone 16 - 2024-10-21 at 18 52 47
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-21 at 18 57 31
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-21 at 18 58 03

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.2 milestone Oct 21, 2024
@kaloudis kaloudis requested a review from shubhamkmr04 October 21, 2024 23:03
@kaloudis kaloudis force-pushed the seed-recovery-columns-margins branch from a535582 to 43be31c Compare October 21, 2024 23:07
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on iOS and android both, looks fine.
but there might be different issue we have when we type in something. left margin becomes 0 compare to right side
Simulator Screenshot - iPhone 16 Pro - 2024-10-22 at 20 27 06

@kaloudis kaloudis force-pushed the seed-recovery-columns-margins branch 2 times, most recently from ed3cc01 to 4e54502 Compare October 22, 2024 15:30
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now they are grouping in the middle which looks odd
Screenshot_1729611453

Screenshot_1729611466

@kaloudis kaloudis force-pushed the seed-recovery-columns-margins branch from 4e54502 to afa2f74 Compare October 22, 2024 15:44
Copy link
Contributor

@shubhamkmr04 shubhamkmr04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis kaloudis merged commit 198e58a into ZeusLN:master Oct 22, 2024
4 checks passed
@kaloudis kaloudis deleted the seed-recovery-columns-margins branch October 22, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants