Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEUS Pay: new device check #2521

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

kaloudis
Copy link
Contributor

@kaloudis kaloudis commented Nov 9, 2024

Description

This PR addresses two issues with ZEUS Pay lightning address.

  • Firstly, when users move to a new device, we now send a newDevice flag to the /submitHashes endpoint that ensures all pending payments are cleared and that all old hashes are deleted.
  • Secondly, it fixes an issues where our old missing preimage error is not thrown after hitting the Redeem all button

Local hash count and a Clear local hashes button are added while in development.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

  • Embedded LND
  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • LndHub
  • [DEPRECATED] Core Lightning (c-lightning-REST)
  • [DEPRECATED] Core Lightning (Spark)
  • [DEPRECATED] Eclair

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@kaloudis kaloudis added this to the v0.9.3 milestone Nov 9, 2024
@kaloudis kaloudis force-pushed the zeus-pay-new-device branch from c39514a to 9b4464b Compare November 9, 2024 04:06
@@ -1052,7 +1072,7 @@ export default class LightningAddressStore {
});
}
}
this.status();
this.status(true);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue #2 addressed here

@kaloudis kaloudis linked an issue Nov 11, 2024 that may be closed by this pull request
@kaloudis kaloudis merged commit b8aab13 into ZeusLN:master Nov 11, 2024
4 checks passed
@kaloudis kaloudis deleted the zeus-pay-new-device branch November 11, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZEUS Pay: auto generate new hashes when moving to new device
1 participant