Skip to content

Commit

Permalink
[1.x][submodule] Upgrade oneDNN to v2.0 (apache#19670)
Browse files Browse the repository at this point in the history
  • Loading branch information
bartekkuncer authored Feb 8, 2021
1 parent 7fba865 commit 031dc5b
Show file tree
Hide file tree
Showing 31 changed files with 38 additions and 13 deletions.
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -169,5 +169,5 @@ coverage.xml
cmake_options.yml

# header file generated at compile time
include/mkldnn/dnnl_version.h
include/mkldnn/dnnl_config.h
include/mkldnn/oneapi/dnnl/dnnl_version.h
include/mkldnn/oneapi/dnnl/dnnl_config.h
2 changes: 1 addition & 1 deletion 3rdparty/mkldnn
Submodule mkldnn updated 502 files
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -815,9 +815,9 @@ endif()
if(USE_MKLDNN)
add_custom_command(TARGET mxnet POST_BUILD
COMMAND ${CMAKE_COMMAND} -E copy
${CMAKE_BINARY_DIR}/3rdparty/mkldnn/include/dnnl_config.h ${CMAKE_SOURCE_DIR}/include/mkldnn/
${CMAKE_BINARY_DIR}/3rdparty/mkldnn/include/oneapi/dnnl/dnnl_config.h ${CMAKE_SOURCE_DIR}/include/mkldnn/oneapi/dnnl/
COMMAND ${CMAKE_COMMAND} -E copy
${CMAKE_BINARY_DIR}/3rdparty/mkldnn/include/dnnl_version.h ${CMAKE_SOURCE_DIR}/include/mkldnn/)
${CMAKE_BINARY_DIR}/3rdparty/mkldnn/include/oneapi/dnnl/dnnl_version.h ${CMAKE_SOURCE_DIR}/include/mkldnn/oneapi/dnnl/)
endif()

if(USE_INTGEMM)
Expand Down
2 changes: 1 addition & 1 deletion cd/mxnet_lib/static/Jenkins_pipeline.groovy
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ licenses = 'licenses/*'

// libmxnet dependencies
mx_native_deps = 'lib/libgfortran.so.3'
mx_deps = 'lib/libgfortran.so.3, 3rdparty/mkldnn/build/install/include/dnnl_version.h, 3rdparty/mkldnn/build/install/include/dnnl_config.h'
mx_deps = 'lib/libgfortran.so.3, 3rdparty/mkldnn/build/install/include/oneapi/dnnl/dnnl_version.h, 3rdparty/mkldnn/build/install/include/oneapi/dnnl/dnnl_config.h'

// library type
// either static or dynamic - depending on how it links to its dependencies
Expand Down
6 changes: 3 additions & 3 deletions cd/python/pypi/pypi_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ export mxnet_variant=${1:?"Please specify the mxnet variant"}
# and CD unpacks it to a directory called cd_misc
# Nov. 2019 Update: With v1.1, MKL-DNN is renaming to DNNL. Hence changing the prefix of file name.
if [ -f "cd_misc/dnnl_version.h" ]; then
mkdir -p 3rdparty/mkldnn/include
cp cd_misc/dnnl_version.h 3rdparty/mkldnn/include/.
cp cd_misc/dnnl_config.h 3rdparty/mkldnn/include/.
mkdir -p 3rdparty/mkldnn/include/oneapi/dnnl
cp cd_misc/dnnl_version.h 3rdparty/mkldnn/include/oneapi/dnnl/.
cp cd_misc/dnnl_config.h 3rdparty/mkldnn/include/oneapi/dnnl/.
fi

# Create wheel workspace
Expand Down
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_config.h
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_debug.h
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_ocl.h
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_ocl.hpp
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_sycl.h
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_sycl.hpp
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_sycl_types.h
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_threadpool.h
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_threadpool.hpp
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_threadpool_iface.hpp
1 change: 1 addition & 0 deletions include/mkldnn/dnnl_version.h
1 change: 1 addition & 0 deletions include/mkldnn/mkldnn_config.h
1 change: 1 addition & 0 deletions include/mkldnn/mkldnn_debug.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl.hpp
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_debug.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_ocl.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_ocl.hpp
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_sycl.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_sycl.hpp
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_sycl_types.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_threadpool.h
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_threadpool.hpp
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_threadpool_iface.hpp
1 change: 1 addition & 0 deletions include/mkldnn/oneapi/dnnl/dnnl_types.h
8 changes: 4 additions & 4 deletions mkldnn.mk
Original file line number Diff line number Diff line change
Expand Up @@ -50,13 +50,13 @@ $(MKLDNN_LIBFILE):
cmake $(MKLDNN_SUBMODDIR) $(mkldnn_FLAGS)
$(MAKE) -C $(MKLDNN_BUILDDIR) VERBOSE=1
$(MAKE) -C $(MKLDNN_BUILDDIR) install
cp $(MKLDNN_BUILDDIR)/include/dnnl_version.h $(MXNET_INCLDIR)/mkldnn/.
cp $(MKLDNN_BUILDDIR)/include/dnnl_config.h $(MXNET_INCLDIR)/mkldnn/.
cp $(MKLDNN_BUILDDIR)/include/oneapi/dnnl/dnnl_version.h $(MXNET_INCLDIR)/mkldnn/oneapi/dnnl/.
cp $(MKLDNN_BUILDDIR)/include/oneapi/dnnl/dnnl_config.h $(MXNET_INCLDIR)/mkldnn/oneapi/dnnl/.

mkldnn_clean:
$(RM) -r 3rdparty/mkldnn/build
$(RM) -r include/mkldnn/dnnl_version.h
$(RM) -r include/mkldnn/dnnl_config.h
$(RM) -r include/mkldnn/oneapi/dnnl/dnnl_version.h
$(RM) -r include/mkldnn/oneapi/dnnl/dnnl_config.h

ifeq ($(USE_MKLDNN), 1)
mkldnn: mkldnn_build
Expand Down

0 comments on commit 031dc5b

Please sign in to comment.