-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick band-aid fix for always visible 1-2 pixel bar #22
base: main
Are you sure you want to change the base?
Conversation
@@ -7,7 +7,7 @@ local StatusBarPrototype = T.StatusBarPrototype | |||
|
|||
function ZUF.HealthClipFrame_HealComm(frame) | |||
if frame.HealCommBar then | |||
ZUF:SetAlpha_HealComm(frame.HealCommBar, 1) | |||
ZUF:SetAlpha_HealComm(frame.HealCommBar, 0) --xD changed from 1 to 0 to start it off hidden avoiding bug yet still have it there so it still positions properly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks raid frame prediction, and I also find this not to be an adequate change since it affects bar creation
absorbBar:SetAlpha(1) | ||
overAbsorb:SetAlpha(1) | ||
end | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would fail if you had one of the IncHeals present. Ideally, for the bandaid to work, I assume you'd have to check the Incoming value for 0 and AlphaHide the respective bar
end | ||
|
||
-- xD end of shit code | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, not all bars are absorb
Perhaps this method is a bit more robust than previous to avoid assumptions that are not always true
I've commented as best I can, -- xD is where I made changes. Hope you can figure out a much cleaner way to fix this after taking a closer look.