Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dijkstra can not work with DirectedWeightedEdge #205

Closed
aengusjiang opened this issue May 9, 2022 · 3 comments · Fixed by #206
Closed

Dijkstra can not work with DirectedWeightedEdge #205

aengusjiang opened this issue May 9, 2022 · 3 comments · Fixed by #206
Labels
bug Something isn't working core something about core good first issue Good for newcomers Priority:High Priority Label for high priority issue

Comments

@aengusjiang
Copy link
Contributor

aengusjiang commented May 9, 2022

Not init for some node dist in Graph.hpp:1007~1009

Please make sure the right iterate container.
It is better that replace as below:
for (const auto &elem : nodeSet )
{
dist[elem.first] = INF_DOUBLE;
}

@github-actions
Copy link

github-actions bot commented May 9, 2022

Thanks you so much for you first Issue, it will be resolved as soon as possible

@ZigRazor
Copy link
Owner

Good Observation!
Thank you so much.
If you have pleasure to solve this, you can contribute to this project. :)

@ZigRazor ZigRazor added bug Something isn't working good first issue Good for newcomers core something about core Priority:High Priority Label for high priority issue labels May 18, 2022
aengusjiang added a commit to aengusjiang/CXXGraph that referenced this issue May 19, 2022
aengusjiang added a commit to aengusjiang/CXXGraph that referenced this issue May 19, 2022
ZigRazor pushed a commit that referenced this issue May 20, 2022
* Fix Dijkstra can not work with DirectedWeightedEdge #205

* Fix Dijkstra can not work with DirectedWeightedEdge #205
@ZigRazor ZigRazor linked a pull request May 20, 2022 that will close this issue
@ZigRazor
Copy link
Owner

Corrected in #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core something about core good first issue Good for newcomers Priority:High Priority Label for high priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants