Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests #85

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Add more tests #85

merged 5 commits into from
Oct 13, 2021

Conversation

sidml
Copy link
Contributor

@sidml sidml commented Oct 13, 2021

Adding new tests to improve code coverage.

@ghost
Copy link

ghost commented Oct 13, 2021

Changes to your CodeSee Architecture Map:

View a CodeSee Map of these changes

View this PR diagram as an interactive map

View more CodeSee Maps

Legend

CodeSee Map Legend

@codecov-commenter
Copy link

Codecov Report

Merging #85 (79508bf) into master (0b18ac2) will increase coverage by 0.74%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage   94.65%   95.39%   +0.74%     
==========================================
  Files          35       35              
  Lines        3349     3413      +64     
==========================================
+ Hits         3170     3256      +86     
+ Misses        179      157      -22     
Flag Coverage Δ
unittests 95.39% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
test/BellmanFordTest.cpp 100.00% <ø> (ø)
test/EdgeTest.cpp 100.00% <100.00%> (ø)
test/RWOutputTest.cpp 98.89% <100.00%> (+0.02%) ⬆️
include/Graph/Graph.hpp 97.52% <0.00%> (+3.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b18ac2...79508bf. Read the comment docs.

@sidml
Copy link
Contributor Author

sidml commented Oct 13, 2021

@ZigRazor
Coverage for Graph.hpp functionalities looks good. RWOutputTest.cpp can be improved further especially the cases where file can't be read or written. I thought TEST(RWOutputTest, test_28) would be enough, but looks like more work is needed.
Please feel free to modify it. If this PR is acceptable then please merge it.

@sidml sidml marked this pull request as ready for review October 13, 2021 09:25
@ZigRazor
Copy link
Owner

RWOutputTest.cpp can be improved further especially the cases where file can't be read or written

Yes, if you want you can improve it.

@ZigRazor ZigRazor merged commit 5a96979 into ZigRazor:master Oct 13, 2021
This was linked to issues Oct 13, 2021
@ZigRazor ZigRazor added this to the In-Depth Tests milestone Oct 13, 2021
@ZigRazor ZigRazor added enhancement New feature or request hacktoberfest hacktoberfest issue test Something about test labels Oct 13, 2021
@ZigRazor ZigRazor self-assigned this Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest hacktoberfest issue test Something about test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Tests on Edge Class Add Tests On Graphs
3 participants