Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical Dependency error from outdated koa-compose #512

Open
amaschas opened this issue Jun 25, 2019 · 1 comment
Open

Critical Dependency error from outdated koa-compose #512

amaschas opened this issue Jun 25, 2019 · 1 comment

Comments

@amaschas
Copy link

koa-router version: 7.4.0

The version of koa-compose (3.0.0) generated the following error in Webpack:

Critical dependency: the request of a dependency is an expression

The current version of koa-compose (4.0.1 as of writing this) eliminated a downstream dependency on the any-promise package which was generating this error. I suggest we upgrade our koa-compose version to the latest if possible to eliminate this error.
@ArthurWD ArthurWD mentioned this issue Nov 12, 2019
Closed
niftylettuce added a commit to koajs/router that referenced this issue Dec 10, 2019
@niftylettuce
chore: bump deps (closes #7, closes #33, fixes ZijianHe/koa-router#512)
c6fc293
@niftylettuce
Copy link

🎉 v8.0.4 of @koa/router has been released to npm

npm i @koa/router@latest or yarn add @koa/router@latest

Thank you for reporting the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niftylettuce @amaschas