Feature/ZCS 10534

[sreejan-chowdhury]

Changes :
Scripts to install rabbitmq, start and stop docservice/spellchecker/coverter;
https for docservice;
change in connection limit;
mysql as db
Updates from https://github.com/ONLYOFFICE/server.git

The branch has been created from tag : v6.3.1.10

The changes can be found in df31f2d

Steps taken :
Created a fork from onlyoffice/server.
Created a branch from v6.3.1.10.
Made changes in the branch.
Created new upstream for ZimbraOS/zm-onlyoffice
pushed new branch to ZimbraOS/zm-onlyoffice

To build on Ubuntu 14:
1.
git clone https://github.com/ONLYOFFICE/build_tools.git
cd build_tools/tools/linux

2. Check : https://jira.corp.synacor.com/browse/ZCS-9616
   In: build_tools/scripts/base.py : def git_update(repo, is_no_errors=False, is_current_dir=False):
   Replace and Add the following:

if repo == "server":
     url = "<repo_address>"
else:
     url = "https://github.com/ONLYOFFICE/" + repo + ".git"

3. python3 ./automate.py --branch= > build2.log 2>&1
4. After the build is complete (more than 7 hrs) , the package can be found in
   ../../out/linux_64/onlyoffice/

[desouzas]

@sreejan-chowdhury Should you:

• create a working tag base branch in this repo from v6.3.1.10
• set this PR base branch to that working tag branch instead of master
• once pr approved and merged: merge that working tag branch (which now includes these changes) to master
  • If the local changes were on top of the git history I would've suggested just rebasing master to latest stuff, then cherry-picking your commits to keep local changes in this repo on top

Less changes for reading.

For reviewers these appear to be local changes:
https://github.com/ONLYOFFICE/server/compare/v6.3.1.10...sreejan-chowdhury:feature/ZCS-10534?expand=1

My comments are not a full review, just casual glance.

[desouzas]

typo (this appears to be from the tag, and not you)

[sreejan-chowdhury]

This is from the tag

[desouzas]

sketchy file changes 😂 (this appears to be from the tag, and not you)

[sreejan-chowdhury]

This is from the tag

[desouzas]

Did you intend to remove this commented line?

[sreejan-chowdhury]

Left it by mistake. Thanks

[desouzas]

Would it be more helpful to show the actual default value (e.g. [default here]) instead of just mentioning there is one? Same for the other prompts in this file.

[sreejan-chowdhury]

This file will no longer be needed.

[thefoolwhocodes]

Better way to do it:
Create a branch from ZimbraOS/zm-onlyoffice tag.
Raise PR against it for better visiblity.

[sreejan-chowdhury]

Better way to do it:
Create a branch from ZimbraOS/zm-onlyoffice tag.
Raise PR against it for better visiblity.

A new base branch from tag v6.3.1.10 has been created for the ease of seeing the changes made by me.

[adriangibanelbtactic]

  content=$(${zmjq} --arg server_crt "$server_crt" '.services.CoAuthoring.ssl.cert=$server_crt' ${defaultjson_path})
  echo "${content}" > ${defaultjson_path}
  content=$(${zmjq} --arg server_crt "$server_crt" '.SpellChecker.ssl.cert=$server_crt' ${defaultjson_path})
  echo "${content}" > ${defaultjson_path}
  content=$(${zmjq} --arg server_key "$server_key" '.services.CoAuthoring.ssl.key=$server_key' ${defaultjson_path})
  echo "${content}" > ${defaultjson_path}
  content=$(${zmjq} --arg server_key "$server_key" '.SpellChecker.ssl.key=$server_key' ${defaultjson_path})
echo "${content}" > ${defaultjson_path}

Similar code is done several times at this new zmonlyofficeconfig file.

Check:

zm-onlyoffice/bin/zmonlyofficeconfig

Lines 123 to 133 in 1a223d3

	content=$(${zmjq} '.services.CoAuthoring.token.enable.browser=true' ${defaultjson_path})
	echo "${content}" > ${defaultjson_path}
	content=$(${zmjq} '.services.CoAuthoring.token.enable.request.inbox=true' ${defaultjson_path})
	echo "${content}" > ${defaultjson_path}
	content=$(${zmjq} '.services.CoAuthoring.token.enable.request.outbox=true' ${defaultjson_path})
	echo "${content}" > ${defaultjson_path}
	content=$(${zmjq} '.services.CoAuthoring.requestDefaults.rejectUnauthorized=false' ${defaultjson_path})
	echo "${content}" > ${defaultjson_path}

.

This is overwriting the same file again with the latest value ( > ) instead of appending values ( >> ), isn't it ?

You should end up with some configuration file which do not have the needed keys for this to work properly.